Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max-download-parallelism validation #2046

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

kislaykishore
Copy link
Collaborator

Reject 0 max-download-parallelism when parallel downloads enabled

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Reject 0 max-download-parallelism when parallel downloads enabled
@kislaykishore kislaykishore requested a review from sethiay June 21, 2024 06:37
@kislaykishore kislaykishore requested a review from a team as a code owner June 21, 2024 06:37
@kislaykishore kislaykishore requested a review from sethiay June 21, 2024 06:47
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.44%. Comparing base (52b1e10) to head (78cde58).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
- Coverage   71.46%   71.44%   -0.03%     
==========================================
  Files          99       99              
  Lines       10800    10802       +2     
==========================================
- Hits         7718     7717       -1     
- Misses       2735     2737       +2     
- Partials      347      348       +1     
Flag Coverage Δ
unittests 71.44% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethiay sethiay self-requested a review June 21, 2024 07:01
@kislaykishore kislaykishore added the execute-integration-tests Run only integration tests label Jun 21, 2024
@kislaykishore kislaykishore merged commit c81eddf into master Jun 21, 2024
13 checks passed
@kislaykishore kislaykishore deleted the config-validation branch June 21, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants