-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default MaxDownloadParallelism based on number of CPU cores #2047
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2047 +/- ##
==========================================
- Coverage 71.95% 71.94% -0.02%
==========================================
Files 99 99
Lines 10870 10872 +2
==========================================
Hits 7822 7822
- Misses 2715 2717 +2
Partials 333 333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sethiay could you update the params.yaml as well? You'll need to make the following changes: |
As discussed offline, we will handle this in a separate PR. |
Description
Use default MaxDownloadParallelism based on number of CPU cores. Also set a minimum value of 16 in case the cores of CPU is less (2 or 4).
Using default 2 * number of cores as with the testing so far with a workload, this value looks good.
And couple of more things to tell upfront :
Link to the issue in case of a bug fix.
NA
Testing details