Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error if the config file is invalid. #2048

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Conversation

kislaykishore
Copy link
Collaborator

@kislaykishore kislaykishore commented Jun 21, 2024

  • Return error if config file is invalid
  • Refactor the root command to make it testable.

Description

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@kislaykishore kislaykishore requested a review from a team as a code owner June 21, 2024 18:25
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.98%. Comparing base (b27d3fd) to head (245171f).
Report is 1 commits behind head on master.

Files Patch % Lines
main.go 0.00% 6 Missing ⚠️
cmd/root.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2048      +/-   ##
==========================================
+ Coverage   71.79%   71.98%   +0.19%     
==========================================
  Files          99       99              
  Lines       10862    10871       +9     
==========================================
+ Hits         7798     7826      +28     
+ Misses       2731     2712      -19     
  Partials      333      333              
Flag Coverage Δ
unittests 71.98% <66.66%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore force-pushed the validate-cfg branch 4 times, most recently from 2b9be8e to b7fef83 Compare June 24, 2024 06:30
* Refactor the root command to make it testable.
* Don't modify the input args; just set the args in the root command.
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@kislaykishore kislaykishore merged commit 76cd8f8 into master Jun 24, 2024
13 checks passed
@kislaykishore kislaykishore deleted the validate-cfg branch June 24, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants