Create new config object from legacy flags and config #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## CLI_config_parity_release #2061 +/- ##
=============================================================
+ Coverage 71.96% 72.12% +0.16%
=============================================================
Files 99 100 +1
Lines 10870 10965 +95
=============================================================
+ Hits 7823 7909 +86
- Misses 2715 2720 +5
- Partials 332 336 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashmeenkaur
changed the base branch from
master
to
dont_use_typecasted_strings_in_mount_config
ashmeenkaur
force-pushed
the
dont_use_typecasted_strings_in_mount_config
branch
from
8b3b628 to
6a77191
Compare
ashmeenkaur
force-pushed
the
create_new_config_from_legacy
branch
from
d7a150e to
35b0808
Compare
ashmeenkaur
changed the title
ashmeenkaur
force-pushed
the
create_new_config_from_legacy
branch
from
35b0808 to
a9490aa
Compare
ashmeenkaur
force-pushed
the
dont_use_typecasted_strings_in_mount_config
branch
from
6a77191 to
5c39d59
Compare
ashmeenkaur
force-pushed
the
create_new_config_from_legacy
branch
2 times, most recently
from
fd21df6 to
1007005
Compare
kislaykishore
requested changes
Jun 25, 2024
ashmeenkaur
force-pushed
the
dont_use_typecasted_strings_in_mount_config
branch
from
4beb095 to
e0e12da
Compare
ashmeenkaur
force-pushed
the
create_new_config_from_legacy
branch
from
1007005 to
163957e
Compare
kislaykishore
requested changes
Jun 25, 2024
Base automatically changed from
dont_use_typecasted_strings_in_mount_config
to
CLI_config_parity_release
June 25, 2024 12:59
ashmeenkaur
force-pushed
the
create_new_config_from_legacy
branch
from
163957e to
9256265
Compare
kislaykishore
requested changes
Jun 26, 2024
ashmeenkaur
requested review from
kislaykishore
and removed request for
raj-prince
kislaykishore
approved these changes
Jun 26, 2024
| } | ||
| } | ||
|
|
||
| func TestOverrideWithFlag(t *testing.T) { |
There was a problem hiding this comment.
We only need to test the API i.e. the public functions. Since we are already testing overlapping flags in the previous test, I think this is not needed.
There was a problem hiding this comment.
will remove in follow up PR
kislaykishore
pushed a commit
that referenced
this pull request
Jun 28, 2024
* changes to populate config * remove unecessary change * add client protocol changes * review comments * review comment * rebase changes * review comments * review comment + unit tests * review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create new config object from legacy flags and legacy mount config.
Link to the issue in case of a bug fix.
NA
Testing details