Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting defaults for parallel downloads #2073

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Setting defaults for parallel downloads #2073

merged 2 commits into from
Jun 27, 2024

Conversation

sethiay
Copy link
Contributor

@sethiay sethiay commented Jun 27, 2024

Description

Setting defaults for parallel downloads.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@sethiay sethiay added the execute-integration-tests Run only integration tests label Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.99%. Comparing base (b8aa8dc) to head (250a1a6).

Files Patch % Lines
cfg/config.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2073      +/-   ##
==========================================
- Coverage   72.34%   71.99%   -0.36%     
==========================================
  Files         100       99       -1     
  Lines       11028    10872     -156     
==========================================
- Hits         7978     7827     -151     
+ Misses       2715     2713       -2     
+ Partials      335      332       -3     
Flag Coverage Δ
unittests 71.99% <0.00%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethiay sethiay marked this pull request as ready for review June 27, 2024 06:46
@sethiay sethiay requested review from kislaykishore and a team as code owners June 27, 2024 06:46
Copy link
Collaborator

@kislaykishore kislaykishore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update params.yaml with the new defaults and generate config.go.

@sethiay sethiay requested a review from kislaykishore June 27, 2024 07:08
@sethiay sethiay merged commit f21483f into master Jun 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants