Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dependencies #2086

Merged
merged 1 commit into from
Jul 2, 2024
Merged

upgrade dependencies #2086

merged 1 commit into from
Jul 2, 2024

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented Jul 1, 2024

Description

This PR is combination of the following dependabot PRs:
#2085
#2053
#2025

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - via KOKORO
  4. Perf tests -
    6XVKH895UBGQABY

@ashmeenkaur ashmeenkaur added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.24%. Comparing base (bc27ee8) to head (977dbd8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2086      +/-   ##
==========================================
- Coverage   72.27%   72.24%   -0.04%     
==========================================
  Files         100      100              
  Lines       10952    10952              
==========================================
- Hits         7916     7912       -4     
- Misses       2707     2711       +4     
  Partials      329      329              
Flag Coverage Δ
unittests 72.24% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashmeenkaur ashmeenkaur changed the title upgrade golang dependencies upgrade dependencies Jul 1, 2024
@ashmeenkaur ashmeenkaur marked this pull request as ready for review July 1, 2024 11:41
@ashmeenkaur ashmeenkaur requested a review from a team as a code owner July 1, 2024 11:41
@ashmeenkaur ashmeenkaur requested a review from raj-prince July 1, 2024 11:41
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we know the reason behind so much fluctuation in throughput of 1 GB, rand read?

@ashmeenkaur
Copy link
Collaborator Author

Do we know the reason behind so much fluctuation in throughput of 1 GB, rand read?

Based on past runs, the observed throughput for 1 GB random reads is typically in the range of 6XX-7XX MiB/s, so this fluctuation is likely a temporary issue.

@ashmeenkaur ashmeenkaur merged commit 63cd70a into master Jul 2, 2024
13 checks passed
@ashmeenkaur ashmeenkaur deleted the bump_dependencies branch July 8, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants