Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do away with the requirement of adding every flag in mount_gcsfuse #2478

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

kislaykishore
Copy link
Collaborator

@kislaykishore kislaykishore commented Sep 13, 2024

  • Get the list of flags from the code-generated list and use that to automatically convert the persistent mount flags to appropriate format.

Description

Link to the issue in case of a bug fix.

https://b.corp.google.com/issues/368503898

Testing details

  1. Manual - NA
  2. Unit tests - Tested with existing unit tests.
  3. Integration tests - NA

@kislaykishore kislaykishore added the execute-integration-tests Run only integration tests label Sep 13, 2024
@kislaykishore kislaykishore requested a review from a team as a code owner September 13, 2024 17:19
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 50.40000% with 62 lines in your changes missing coverage. Please review.

Project coverage is 78.84%. Comparing base (a738c2a) to head (60810da).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cfg/config.go 51.23% 13 Missing and 46 partials ⚠️
cmd/root.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2478      +/-   ##
==========================================
- Coverage   78.88%   78.84%   -0.05%     
==========================================
  Files         106      106              
  Lines       11686    11690       +4     
==========================================
- Hits         9219     9217       -2     
- Misses       1989     1993       +4     
- Partials      478      480       +2     
Flag Coverage Δ
unittests 78.84% <50.40%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kislaykishore kislaykishore changed the title Do away with the requirement of adding every flags in mount_gcsfuse Do away with the requirement of adding every flag in mount_gcsfuse Sep 15, 2024
@kislaykishore kislaykishore requested review from a team and BrennaEpp and removed request for a team September 20, 2024 07:27
ashmeenkaur
ashmeenkaur previously approved these changes Sep 23, 2024
@kislaykishore kislaykishore merged commit b33f36e into master Sep 23, 2024
13 checks passed
@kislaykishore kislaykishore deleted the flags branch September 23, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants