-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do away with the requirement of adding every flag in mount_gcsfuse #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2478 +/- ##
==========================================
- Coverage 78.88% 78.84% -0.05%
==========================================
Files 106 106
Lines 11686 11690 +4
==========================================
- Hits 9219 9217 -2
- Misses 1989 1993 +4
- Partials 478 480 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
changed the title
Do away with the requirement of adding every flags in mount_gcsfuse
Do away with the requirement of adding every flag in mount_gcsfuse
Sep 15, 2024
* Get the list of flags from the code-generated list and use that to automatically convert the persistent mount flags to appropriate format.
kislaykishore
force-pushed
the
flags
branch
from
September 20, 2024 07:26
adac4e8
to
87b898b
Compare
kislaykishore
requested review from
a team and
BrennaEpp
and removed request for
a team
September 20, 2024 07:27
ashmeenkaur
reviewed
Sep 23, 2024
ashmeenkaur
previously approved these changes
Sep 23, 2024
ashmeenkaur
reviewed
Sep 23, 2024
ashmeenkaur
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to the issue in case of a bug fix.
https://b.corp.google.com/issues/368503898
Testing details