Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make createFolder and deleteFolder retry able #2565

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

Tulsishah
Copy link
Collaborator

@Tulsishah Tulsishah commented Oct 9, 2024

Description

We've recently observed some failures in our end-to-end tests when calling the CreateFolder API. The error message reads:

"MkDir: input/output error, CreateChildDir: rpc error: code = Internal desc = We encountered an internal error. Please try again." 

In this, we initially made this error non-retryable because the go-sdk wasn't retrying it. However, we're reverting that change because we're encountering this error frequently in GCSFuse, necessitating a retry mechanism on our end.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Already_Exist error code returned when retrying to Create already created folder and Not_found for deleting folder which is already deleted, these error codes are not part of retry.
  2. Unit tests - NA
  3. Integration tests - Automated

@Tulsishah Tulsishah added the execute-integration-tests Run only integration tests label Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (4380816) to head (648c5d2).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2565      +/-   ##
==========================================
- Coverage   78.36%   78.30%   -0.07%     
==========================================
  Files         107      107              
  Lines       11751    11795      +44     
==========================================
+ Hits         9209     9236      +27     
- Misses       2062     2070       +8     
- Partials      480      489       +9     
Flag Coverage Δ
unittests 78.30% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tulsishah Tulsishah marked this pull request as ready for review October 9, 2024 09:57
@Tulsishah Tulsishah requested a review from a team as a code owner October 9, 2024 09:57
@kislaykishore kislaykishore requested review from a team, kislaykishore and gargnitingoogle and removed request for a team and kislaykishore October 9, 2024 09:58
@kislaykishore kislaykishore requested review from a team and ankitaluthra1 and removed request for ankitaluthra1 October 9, 2024 09:58
@Tulsishah Tulsishah merged commit f6a8a10 into master Oct 9, 2024
22 checks passed
ashmeenkaur pushed a commit that referenced this pull request Oct 9, 2024
* make createFolder and deleteFolder retryable

* lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants