-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reducing list API payload #2627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2627 +/- ##
==========================================
- Coverage 77.56% 77.49% -0.07%
==========================================
Files 109 109
Lines 15576 15603 +27
==========================================
+ Hits 12081 12092 +11
- Misses 2979 2992 +13
- Partials 516 519 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
requested review from
a team,
tritone and
gargnitingoogle
and removed request for
a team and
tritone
October 24, 2024 13:45
anushka567
requested review from
tritone and
vadlakondaswetha
and removed request for
gargnitingoogle
October 24, 2024 13:45
kislaykishore
requested review from
gargnitingoogle,
a team,
tritone and
vadlakondaswetha
and removed request for
tritone,
vadlakondaswetha and
gargnitingoogle
October 24, 2024 13:46
anushka567
force-pushed
the
reduce-list-api-payload
branch
from
October 25, 2024 09:27
44603f3
to
98e6bb3
Compare
anushka567
force-pushed
the
reduce-list-api-payload
branch
from
November 5, 2024 05:19
98e6bb3
to
f25156b
Compare
vadlakondaswetha
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fetching only selected attributes using query.SetAttrSelection for ListObjects API which are sufficient for serving the request and reduce the payload for network call.
Reduction in payload : ~75%
Reduction in latency : ~8.5%
Also included : necessary changes in the fake bucket tests.
Perf Metrics for listing :
Note: More detailed metrics here
Link to the issue in case of a bug fix.
NA
Testing details