feat: add tracing to main #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
requested changes
May 13, 2024
| del session["history"] | ||
| base_history = self.get_base_history(session) | ||
| session["history"] = [base_history] | ||
| history = self.parse_messages(session["history"]) | ||
| user_session.reset_memory(history) | ||
|
|
||
| # clear session traces | ||
| del self._user_traces[uuid] | ||
| tool_trace = ToolTrace() |
There was a problem hiding this comment.
do we need to hang on to ToolTrace if it's used by tools?
There was a problem hiding this comment.
ToolTrace is connected to each user session (to prevent it from sending the wrong tooltrace to another user. (it is similar to _user_sessions. There is another way to do this by initializing it and hanging on to it within UserAgent. What do you think about that?
Comment on lines
88
to
89
| if response_json.get("trace"): | ||
| tool_trace.add_message(response_json.get("trace")) |
There was a problem hiding this comment.
Suggested change
| if response_json.get("trace"): | |
| tool_trace.add_message(response_json.get("trace")) | |
| trace = response_json.get("trace") | |
| if trace: | |
| tool_trace.add_message(trace) |
There was a problem hiding this comment.
Do we need to validate trace is in the right format somewhere?
There was a problem hiding this comment.
"trace" are build in retrieval service/app/routes.py (src code is in: retrieval_service/helpers/helpers.py) before sending it back to the UI.
Yuan325
force-pushed
the
add-tracing
branch
3 times, most recently
from
55a31cb
to
96c5336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tracing to main. This PR add tracing for postgres.py provider and langchain orchestration.