feat: Adding support for Spanner with PG Dialect in Database Retriever Service #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gauravpurohit06
commented
May 2, 2024
gauravpurohit06
commented
- Adding support for Spanner with PG Dialect in Database Retriever Service.
- Queries are used based on auto dialect detection.
gauravpurohit06
changed the title
Yuan325
reviewed
May 17, 2024
| """ | ||
| WHERE (COALESCE({country}) IS NULL OR LOWER(country) LIKE LOWER({country})) | ||
| AND (COALESCE({city}) IS NULL OR LOWER(city) LIKE LOWER({city})) | ||
| AND (COALESCE({name}) IS NULL OR LOWER(name) LIKE '%' || LOWER({name}) || '%') |
There was a problem hiding this comment.
Add LIMIT 10 (changes here: #369)
| """, | ||
| params={"airline": airline, "number": number}, | ||
| WHERE airline = {} | ||
| AND flight_number = {} |
| WHERE (COALESCE({departure_airport}) IS NULL OR LOWER(departure_airport) LIKE LOWER({departure_airport})) | ||
| AND (COALESCE({arrival_airport}) IS NULL OR LOWER(arrival_airport) LIKE LOWER({arrival_airport})) | ||
| AND cast(departure_time as TIMESTAMP) >= CAST({datetime} AS TIMESTAMP) | ||
| AND cast(departure_time as TIMESTAMP) < TIMESTAMP_ADD(CAST({datetime} AS TIMESTAMP), INTERVAL 1 DAY) |
| WHERE (COALESCE({departure_airport}) IS NULL OR LOWER(departure_airport) LIKE LOWER({departure_airport})) | ||
| AND (COALESCE({arrival_airport}) IS NULL OR LOWER(arrival_airport) LIKE LOWER({arrival_airport})) | ||
| AND CAST(departure_time as timestamptz) >= CAST({datetime} AS timestamptz) | ||
| AND cast(departure_time as timestamptz) < spanner.timestamptz_add(CAST({datetime} AS timestamptz), '1 day') |
|
Closing it and changes are tracked on #402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.