chore: implement langgraph #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
requested changes
Jul 8, 2024
Comment on lines
81
to
100
| def call_model(state: UserState, config: RunnableConfig): | ||
| """ | ||
| Node for function that calls the model | ||
| """ | ||
| messages = state["messages"] | ||
| response = model_runnable.invoke(messages, config) | ||
| if ( | ||
| state["is_last_step"] | ||
| and isinstance(response, AIMessage) | ||
| and response.tool_calls | ||
| ): | ||
| return { | ||
| "messages": [ | ||
| AIMessage( | ||
| id=response.id, | ||
| content="Sorry, need more steps to process this request.", | ||
| ) | ||
| ] | ||
| } | ||
| return {"messages": [response]} |
There was a problem hiding this comment.
Why is this function inline? Can we get a comment or explanation as to what it is doing?
There was a problem hiding this comment.
This is written similarly to the prebuilt react_agent. Let me know if it's better to move it out (so that this isn't inline).
Comment on lines
102
to
112
| def agent_should_continue(self, state: UserState) -> Literal["tools", "end"]: | ||
| """ | ||
| Function to determine which node is called next | ||
| """ | ||
| messages = state["messages"] | ||
| last_message = messages[-1] | ||
| # If the LLM makes a tool call, then we route to the "tools" node | ||
| if isinstance(last_message, AIMessage) and last_message.tool_calls: | ||
| return "tools" | ||
| # Otherwise, we stop (reply to the user) | ||
| return "end" |
There was a problem hiding this comment.
Same with this function -- does it need to be inline?
Yuan325
force-pushed
the
langgraph-implementation
branch
from
59cf2c6
to
825125c
Compare
Yuan325
force-pushed
the
langgraph-implementation
branch
from
825125c
to
fc1b51c
Compare
kurtisvg
approved these changes
Jul 22, 2024
Yuan325
added a commit
that referenced
this pull request
Jul 26, 2024
Update implementation to langgraph. Main changes: - We create a `UserAgent` for each session in langchain orchestration. For langgraph, we create a single graph and use `config` with `thread_id` to keep track of session. This PR does not include the following: - human-in-the-loop workflow (e.g. book ticket confirmation from user). - initialize tools with user-specific client. Currently the tools is initialized with a single client (each session/user is supposed to have their own client). Will create a custom ToolNode in another PR so that the Tool is able to get user's `client` object from the state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update implementation to langgraph.
Main changes:
UserAgentfor each session in langchain orchestration. For langgraph, we create a single graph and useconfigwiththread_idto keep track of session.This PR does not include the following:
clientobject from the state.