Add localhost tests to Travis. #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script will allow us to run tests against a local server for testing. Since the App Engine and Jetty server running and testing is so similar, I combined the scripts rather than copying. The only differences are which plugin to use and what string to wait for before running curl. Since the bookshelf sample also needs a `-Plocal` profile argument, I extended the script to allow passing through arbitrary arguments to Maven.
Run the local servers and verify they respond with code 200 to the "/" path. Note: bookshelf does not yet run in Travis, since we'll need to set up client secrets credentials.
googlebot
added
the
cla: yes
| echo " $0 server-type path/to/project [-- maven arguments]" >&2 | ||
| echo >&2 | ||
| echo "server-type can be any of the following:" >&2 | ||
| echo " appengine" >&2 |
There was a problem hiding this comment.
Standard. The names match those of the Maven plugins, but I suppose that could as we add more kinds of samples.
|
Consider comments, Ok if you choose not to change - LGTM |
tswast
added a commit
to GoogleCloudPlatform/java-docs-samples
that referenced
this pull request
Jun 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the local servers and verify they respond with code 200 to the "/"
path.
Note: bookshelf does not yet run in Travis, since we'll need to set up
client secrets credentials.