Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring region for Regional Backend config may be unnecessary and confusing #41

Open
rwkarg opened this issue Aug 4, 2021 · 4 comments
Milestone

Comments

@rwkarg
Copy link

rwkarg commented Aug 4, 2021

I missed this when looking at #34 but I don't think there's any opportunity to make choices for the backend region.

An Internal HTTP LB (regional backend service) can only include Backends from the same region. So a Backend Service in us-west1 can only have Backends also in us-west1. Trying to configure autoneg on a us-west1 cluster to add instances to a us-east1 Backend Service will not work, I believe.

I addressed this by pulling the cluster location (region) from metadata: http://metadata.google.internal/computeMetadata/v1/instance/attributes/cluster-location so that user's aren't in the position of needing to magically know the only value that will actually work for region and having to explicitly configure it for each annotation.

One thing that may make this configuration required would be if there's potential for an Internal HTTP LB at some point in the future to allow Backends to be added to a Backend Service in a different region. If that happens, the it would become necessary to specify the Backend Service region in the annotation.

@rosmo
Copy link
Collaborator

rosmo commented Aug 4, 2021

Fair point, I guess we could use region:"auto" or similar for that functionality.

@soellman
Copy link
Contributor

soellman commented Aug 5, 2021

Is there a case where we would want more than regional:true? Or can we think of any upcoming case?

@rwkarg
Copy link
Author

rwkarg commented Aug 5, 2021

With the current functionality of global and regional backend services, just a regional: true setting is all that is needed.

I know there is an expressed desire for Internal HTTP Load Balancers to allow for global access, similar to how Internal TCP/UDP Load Balancers can be configured for global/cross-region access today. But I don’t know if that is being worked on or if whenever something like that got it mplemented would still restrict backends to a single region or expand that out.

@rosmo
Copy link
Collaborator

rosmo commented Aug 5, 2021

We can add support for regional boolean in addition to specifying the region manually. No harm in having both options.

rosmo added a commit to rosmo/gke-autoneg-controller that referenced this issue Aug 6, 2021
rosmo added a commit to rosmo/gke-autoneg-controller that referenced this issue Aug 6, 2021
@soellman soellman added this to the 1.0 milestone Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants