This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Supporting Ingress policies. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support Ingress policies, we need to modify a bit the API, so we introduce a v1alpha2. It adds the "ingress" section to the CRD, but also a policyType like the one used in NetworkPolicies. The behavior of that policyType makes this a non-backward compatible change. This commit only introduces the new API. There is no actual implementation yet.
Same check as for egress policies.
|
@thesmiler This is ready for your review |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current status of PR:
I only have the API definition for now. There is no implementation yet.Ready for reviewTo support Ingress policies, we need to modify a bit the API, so we introduce a v1alpha2.
It adds the "ingress" section to the CRD, but also a policyType like the one used in NetworkPolicies.
The behaviour of that policyType makes this a non-backward compatible change.
In theory, we could support both v1alpha1 and v1alpha2 in parallel, but that seems a lot of hassle for not many advantages.
Fixes #7