This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
allow skiping ipv6 lookup by adding aaaa-lookups annotation #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Théo,
as suggested in issue #24 , here's the adapted code, basically just introducing a check whether the annotation
fqdnnetworkpolicies.networking.gke.io/aaaa-lookups
is set toskip
in the FQDNNetworkPolicy.I tested this locally with following manifest:
Both scenarios, with and without the
fqdnnetworkpolicies.networking.gke.io/aaaa-lookups
annotation, the code produces the expected NetworkPolicy.I have to admit, I haven't added a test - if that is strictly required, please let me know.
Please, feel free to adapt to your naming schema or coding guidelines.
Thanks a lot
Karsten