Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for the .NET Core 2.0 runtime. #785

Conversation

ivannaranjo
Copy link
Contributor

This PR adds detection code for .NET Core 2.0, and adds support for deploying .NET Core 2.0 apps to the extension.

@ivannaranjo ivannaranjo requested a review from ILMTitan August 23, 2017 10:27
@codecov
Copy link

codecov bot commented Aug 23, 2017

Codecov Report

Merging #785 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
- Coverage   10.47%   10.46%   -0.01%     
==========================================
  Files         496      496              
  Lines       12125    12130       +5     
==========================================
  Hits         1270     1270              
- Misses      10855    10860       +5
Impacted Files Coverage Δ
...loudExtension/PublishDialog/PublishDialogWindow.cs 0% <0%> (ø) ⬆️
...blishDialogSteps/ChoiceStep/ChoiceStepViewModel.cs 0% <0%> (ø) ⬆️
...GoogleCloudExtension.Deployment/NetCoreAppUtils.cs 0% <0%> (ø) ⬆️
CsprojProject.cs 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12eb108...e068e1a. Read the comment docs.

Copy link

@ILMTitan ILMTitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typo and LGTM.

/// <summary>
/// An ASP.NET Core 2.0 app
/// </summary>
NetCoreWEbApplication2_0,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NetCoreWEbApplication2_0 -> NetCoreWebApplication2_0

@ivannaranjo ivannaranjo merged commit bb327ee into GoogleCloudPlatform:master Aug 25, 2017
@ivannaranjo ivannaranjo deleted the master_adding_dotnetcore_2_0_support branch August 25, 2017 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants