Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated imp module with importlib #1695

Closed
hugovk opened this issue Apr 29, 2023 · 2 comments
Closed

Replace deprecated imp module with importlib #1695

hugovk opened this issue Apr 29, 2023 · 2 comments

Comments

@hugovk
Copy link
Contributor

hugovk commented Apr 29, 2023

This project, via vendored boto, uses the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.
@hugovk hugovk mentioned this issue May 3, 2023
Open
31 tasks
@thomasmaclean
Copy link
Contributor

I made an attempt at resolving this here, as imp wasn't used particularly frequently in boto:

https://github.com/gsutil-mirrors/boto/pull/21/files

thomasmaclean added a commit to thomasmaclean/gsutil that referenced this issue Jun 9, 2023
@thomasmaclean
Updating to include latest boto changes, addressing GoogleCloudPlatfo…
a6a4113 
…rm#1695
thomasmaclean added a commit that referenced this issue Jun 21, 2023
@thomasmaclean
Updating to include latest boto changes, addressing #1695 (#1715)
b36ede9 
* Updating to include latest boto changes, addressing #1695

* Including key.py fix.

* Fixed key.py issue
@hugovk
Copy link
Contributor Author

hugovk commented Jun 7, 2024

mtth/hdfs#192 has been merged, I think this can be closed now.

@hugovk hugovk closed this as completed Jun 7, 2024
@cHiv0rz cHiv0rz mentioned this issue Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugovk @thomasmaclean