Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make signurl work with objects containing tildes. #783

Merged
merged 1 commit into from
May 20, 2019

Commits on May 20, 2019

  1. Make signurl work with objects containing tildes.

    Fixes https://issuetracker.google.com/issues/133019153
    
    Per the docs, the tilde character should not be percent-encoded:
    
    When defining the path to the resource, you must percent encode the
    following reserved characters: ?=!#$&'()*+,:;@[]."
    
    https://cloud.google.com/storage/docs/access-control/signing-urls-manually
    
    Note that Python 3's urllib quote method ignores the tilde, but Python
    2's does not:
    - Py2 docs: "Letters, digits, and the characters '_.-' are never quoted."
    - Py3 docs: "Letters, digits, and the characters '_.-~' are never quoted."
    houglum committed May 20, 2019
    Configuration menu
    Copy the full SHA
    cd2048e View commit details
    Browse the repository at this point in the history