Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests in asset/cloud-client are inherently flaky #2715

Closed
lesv opened this issue Apr 21, 2020 · 3 comments · Fixed by #2716
Closed

tests in asset/cloud-client are inherently flaky #2715

lesv opened this issue Apr 21, 2020 · 3 comments · Fixed by #2716
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@lesv
Copy link
Contributor

lesv commented Apr 21, 2020

Reviewing QuickstartIT, it:

  • creates a bucket
  • Writes a list of assets to the bucket
  • wants to see that bucket in the list of assets
  • deletes the bucket.

It should instead:

  • Write to a well known bucket w/ gs:/well-known-bucket/UUID/my-assets.txt
  • See if well-known-bucket is in my-assets.txt

This way there isn't a hysteresis problem on creating and knowing about buckets.

Related to #2551
@lesv lesv added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. api: cloudasset Issues related to the Cloud Asset Inventory API. labels Apr 21, 2020
@lesv lesv self-assigned this Apr 21, 2020
@lesv
Copy link
Contributor Author

lesv commented Apr 21, 2020

FYI @peter-zheng-g @dzlier-gcp @kurtisvg

lesv pushed a commit that referenced this issue Apr 21, 2020
Update QuickStartIT.java
3833d56 
Fixes: #2715
Reviewing QuickstartIT, it:

* creates a bucket
* Writes a list of assets to the bucket
* wants to see that bucket in the list of assets
* deletes the bucket.
It should instead:

* Write to a well known bucket w/ gs:/well-known-bucket/UUID/my-assets.txt
* See if well-known-bucket is in my-assets.txt
This way there isn't a hysteresis problem on creating and knowing about buckets.
@lesv lesv mentioned this issue Apr 21, 2020
Merged
5 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 22, 2020
@lesv
Update QuickStartIT.java (#2716)
1e860dc 
Fixes: #2715
Reviewing QuickstartIT, it:

* creates a bucket
* Writes a list of assets to the bucket
* wants to see that bucket in the list of assets
* deletes the bucket.

It should instead:

* Write to a well known bucket w/ gs:/well-known-bucket/UUID/my-assets.txt
* See if well-known-bucket is in my-assets.txt
This way there isn't a hysteresis problem on creating and knowing about buckets.

- [x] `pom.xml` parent set to latest `shared-configuration`
- [x] Appropriate changes to README are included in PR
- [x] API's need to be enabled to test (tell us)
- [x] Environment Variables need to be set (ask us to set them)
- [x] Tests pass (`mvn -P lint clean verify`)
  * (Note- `Checkstyle` passing is required; `Spotbugs`, `ErrorProne`, `PMD`, etc. `ERROR`'s are advisory only)
@elharo
Copy link
Contributor

elharo commented Apr 22, 2020

I don't follow why this test is flaky. The current flow seems like it should work?

@lesv
Copy link
Contributor Author

lesv commented Apr 22, 2020

It was creating a bucket, then immediatly dealing w/ it. What was happening was that occasionally, the bucket wasn't yet available. That's fixed now.

@lesv lesv removed their assignment Jul 17, 2022
minherz pushed a commit that referenced this issue Nov 16, 2022
@lesv @chingor13
Update QuickStartIT.java (#2716)
1885c3a 
Fixes: #2715
Reviewing QuickstartIT, it:

* creates a bucket
* Writes a list of assets to the bucket
* wants to see that bucket in the list of assets
* deletes the bucket.

It should instead:

* Write to a well known bucket w/ gs:/well-known-bucket/UUID/my-assets.txt
* See if well-known-bucket is in my-assets.txt
This way there isn't a hysteresis problem on creating and knowing about buckets.

- [x] `pom.xml` parent set to latest `shared-configuration`
- [x] Appropriate changes to README are included in PR
- [x] API's need to be enabled to test (tell us)
- [x] Environment Variables need to be set (ask us to set them)
- [x] Tests pass (`mvn -P lint clean verify`)
  * (Note- `Checkstyle` passing is required; `Spotbugs`, `ErrorProne`, `PMD`, etc. `ERROR`'s are advisory only)
minherz pushed a commit that referenced this issue Nov 17, 2022
@lesv @minherz
Update QuickStartIT.java (#2716)
a8be911 
Fixes: #2715
Reviewing QuickstartIT, it:

* creates a bucket
* Writes a list of assets to the bucket
* wants to see that bucket in the list of assets
* deletes the bucket.

It should instead:

* Write to a well known bucket w/ gs:/well-known-bucket/UUID/my-assets.txt
* See if well-known-bucket is in my-assets.txt
This way there isn't a hysteresis problem on creating and knowing about buckets.

- [x] `pom.xml` parent set to latest `shared-configuration`
- [x] Appropriate changes to README are included in PR
- [x] API's need to be enabled to test (tell us)
- [x] Environment Variables need to be set (ask us to set them)
- [x] Tests pass (`mvn -P lint clean verify`)
  * (Note- `Checkstyle` passing is required; `Spotbugs`, `ErrorProne`, `PMD`, etc. `ERROR`'s are advisory only)
anguillanneuf pushed a commit that referenced this issue Dec 5, 2022
@lesv @anguillanneuf
Update QuickStartIT.java (#2716)
210b30a 
Fixes: #2715
Reviewing QuickstartIT, it:

* creates a bucket
* Writes a list of assets to the bucket
* wants to see that bucket in the list of assets
* deletes the bucket.

It should instead:

* Write to a well known bucket w/ gs:/well-known-bucket/UUID/my-assets.txt
* See if well-known-bucket is in my-assets.txt
This way there isn't a hysteresis problem on creating and knowing about buckets.

- [x] `pom.xml` parent set to latest `shared-configuration`
- [x] Appropriate changes to README are included in PR
- [x] API's need to be enabled to test (tell us)
- [x] Environment Variables need to be set (ask us to set them)
- [x] Tests pass (`mvn -P lint clean verify`)
  * (Note- `Checkstyle` passing is required; `Spotbugs`, `ErrorProne`, `PMD`, etc. `ERROR`'s are advisory only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update QuickStartIT.java GoogleCloudPlatform/java-docs-samples
2 participants
@elharo @lesv