Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build issues caused by dependency update. #1055

Merged
merged 2 commits into from
Mar 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .kokoro/presubmit.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,3 @@ env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/java-docs-samples/.kokoro/tests/diff_tests.sh"
}

1 change: 0 additions & 1 deletion appengine/datastore/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,4 @@
<module>indexes-exploding</module>
<module>indexes-perfect</module>
</modules>

</project>
2 changes: 1 addition & 1 deletion container-registry/container-analysis/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-pubsub</artifactId>
<version>0.34.0-beta</version>
<version>0.38.0-beta</version>
</dependency>
<dependency>
<groupId>com.google.api</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@
import com.google.containeranalysis.v1alpha1.Occurrence;
import com.google.containeranalysis.v1alpha1.VulnerabilityType;
import com.google.containeranalysis.v1alpha1.VulnerabilityType.VulnerabilityDetails;
import com.google.pubsub.v1.ProjectSubscriptionName;
import com.google.pubsub.v1.ProjectTopicName;
import com.google.pubsub.v1.PubsubMessage;
import com.google.pubsub.v1.PushConfig;
import com.google.pubsub.v1.Subscription;
import com.google.pubsub.v1.SubscriptionName;
import com.google.pubsub.v1.TopicName;

/**
* API usage samples
Expand Down Expand Up @@ -292,7 +292,7 @@ public static int pubSub(String subscriptionId, int timeout, String projectId) t

try {
// subscribe to the requested pubsub channel
SubscriptionName subscriptionName = SubscriptionName.of(projectId, subscriptionId);
ProjectSubscriptionName subscriptionName = ProjectSubscriptionName.of(projectId, subscriptionId);
subscriber = Subscriber.newBuilder(subscriptionName, receiver).build();
subscriber.startAsync().awaitRunning();
// listen to messages for 'listenTimeout' seconds
Expand Down Expand Up @@ -339,8 +339,8 @@ public static Subscription createOccurrenceSubscription(String subscriptionId, S
String topicId = "resource-notes-occurrences-v1alpha1";
try (SubscriptionAdminClient client = SubscriptionAdminClient.create()) {
PushConfig config = PushConfig.getDefaultInstance();
TopicName topicName = TopicName.of(projectId, topicId);
SubscriptionName subscriptionName = SubscriptionName.of(projectId, subscriptionId);
ProjectTopicName topicName = ProjectTopicName.of(projectId, topicId);
ProjectSubscriptionName subscriptionName = ProjectSubscriptionName.of(projectId, subscriptionId);
Subscription sub = client.createSubscription(subscriptionName, topicName, config, 0);
return sub;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import com.google.containeranalysis.v1alpha1.Note;
import com.google.containeranalysis.v1alpha1.Occurrence;
import com.google.containeranalysis.v1alpha1.VulnerabilityType.VulnerabilityDetails;
import com.google.pubsub.v1.SubscriptionName;
import com.google.pubsub.v1.ProjectSubscriptionName;
import java.util.Date;
import org.junit.After;
import org.junit.Before;
Expand Down Expand Up @@ -194,7 +194,7 @@ public void testPubSub() throws Exception {
int newCount;
int tries;
String subscriptionId = "drydockOccurrences";
SubscriptionName subscriptionName = SubscriptionName.of(PROJECT_ID, subscriptionId);
ProjectSubscriptionName subscriptionName = ProjectSubscriptionName.of(PROJECT_ID, subscriptionId);

Samples.createOccurrenceSubscription(subscriptionId, PROJECT_ID);
Subscriber subscriber = null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@
@SuppressWarnings("checkstyle:abbreviationaswordinname")
public class SpannerGroupWriteIT {

String instanceId;
String databaseId;
private String instanceId;
private String databaseId;

Path tempPath;
Spanner spanner;
SpannerOptions spannerOptions;
private Path tempPath;
private Spanner spanner;
private SpannerOptions spannerOptions;

@Before
public void setUp() throws Exception {
Expand Down Expand Up @@ -93,7 +93,7 @@ public void setUp() throws Exception {

@Nullable
@Override
public Void run(TransactionContext tx) throws Exception {
public Void run(TransactionContext tx) {
tx.buffer(mutations);
return null;
}
Expand All @@ -106,7 +106,7 @@ public Void run(TransactionContext tx) throws Exception {
}

@After
public void tearDown() throws Exception {
public void tearDown() {
DatabaseAdminClient adminClient = spanner.getDatabaseAdminClient();
try {
adminClient.dropDatabase(instanceId, databaseId);
Expand All @@ -118,7 +118,7 @@ public void tearDown() throws Exception {
}

@Test
public void testEndToEnd() throws Exception {
public void testEndToEnd() {
SpannerGroupWrite.main(
new String[] { "--instanceId=" + instanceId, "--databaseId=" + databaseId,
"--suspiciousUsersFile=" + tempPath, "--runner=DirectRunner" });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@
@SuppressWarnings("checkstyle:abbreviationaswordinname")
public class SpannerReadIT {

String instanceId;
String databaseId;
private String instanceId;
private String databaseId;

Spanner spanner;
SpannerOptions spannerOptions;
private Spanner spanner;
private SpannerOptions spannerOptions;

@Before
public void setUp() throws Exception {
public void setUp() {
instanceId = System.getProperty("spanner.test.instance");
databaseId = "df-spanner-read-it";

Expand Down Expand Up @@ -115,15 +115,15 @@ public void setUp() throws Exception {
runner.run(new TransactionRunner.TransactionCallable<Void>() {
@Nullable
@Override
public Void run(TransactionContext tx) throws Exception {
public Void run(TransactionContext tx) {
tx.buffer(mutations);
return null;
}
});
}

@After
public void tearDown() throws Exception {
public void tearDown() {
DatabaseAdminClient adminClient = spanner.getDatabaseAdminClient();
try {
adminClient.dropDatabase(instanceId, databaseId);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@
@SuppressWarnings("checkstyle:abbreviationaswordinname")
public class SpannerWriteIT {

String instanceId;
String databaseId;
private String instanceId;
private String databaseId;

Path singersPath;
Path albumsPath;
Spanner spanner;
SpannerOptions spannerOptions;
private Path singersPath;
private Path albumsPath;
private Spanner spanner;
private SpannerOptions spannerOptions;

@Before
public void setUp() throws Exception {
Expand Down Expand Up @@ -95,7 +95,7 @@ public void setUp() throws Exception {
}

@After
public void tearDown() throws Exception {
public void tearDown() {
DatabaseAdminClient adminClient = spanner.getDatabaseAdminClient();
try {
adminClient.dropDatabase(instanceId, databaseId);
Expand All @@ -107,7 +107,7 @@ public void tearDown() throws Exception {
}

@Test
public void testEndToEnd() throws Exception {
public void testEndToEnd() {
SpannerWrite.main(new String[] { "--instanceId=" + instanceId, "--databaseId=" + databaseId,
"--singersFilename=" + singersPath, "--albumsFilename=" + albumsPath,
"--runner=DirectRunner" });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public static void main(String[] args) throws Exception {

// Google Cloud Platform Project ID
String projectId = (args.length > 0) ? args[0] : ServiceOptions.getDefaultProjectId();
ProjectName projectName = ProjectName.create(projectId);
ProjectName projectName = ProjectName.of(projectId);

// Instantiate an Error Reporting Client
try (ReportErrorsServiceClient reportErrorsServiceClient = ReportErrorsServiceClient.create()) {
Expand Down
2 changes: 1 addition & 1 deletion monitoring/cloud-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-monitoring</artifactId>
<version>0.34.0-beta</version>
<version>0.38.0-beta</version>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public static void main(String... args) throws Exception {
List<Point> pointList = new ArrayList<>();
pointList.add(point);

ProjectName name = ProjectName.create(projectId);
ProjectName name = ProjectName.of(projectId);

// Prepares the metric descriptor
Map<String, String> metricLabels = new HashMap<String, String>();
Expand Down Expand Up @@ -93,7 +93,7 @@ public static void main(String... args) throws Exception {
timeSeriesList.add(timeSeries);

CreateTimeSeriesRequest request = CreateTimeSeriesRequest.newBuilder()
.setNameWithProjectName(name)
.setName(name.toString())
.addAllTimeSeries(timeSeriesList)
.build();

Expand Down
Loading