[DO NOT MERGE] Microphone streaming - multi-threaded #1130

nirupa-kumar · 2018-06-14T18:02:44Z

For @Beccca preliminary review

…docs-samples into microphone-streaming

…to microphone-streaming

googlebot · 2018-06-14T18:02:48Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

dzlier-gcp · 2018-06-18T17:27:39Z

speech/cloud-client/src/main/java/com/example/speech/MicStreamRecognize.java

@@ -0,0 +1,213 @@
+/*
+ * Copyright 2018 Google Inc.


s/Inc./LLC/

This applies to all files.

dzlier-gcp · 2018-06-18T17:30:26Z

speech/cloud-client/src/main/java/com/example/speech/MicStreamRecognize.java

+      StreamingRecognitionConfig config =
+          StreamingRecognitionConfig.newBuilder().setConfig(recConfig).build();
+
+      class ResponseApiStreamingObserver<T> implements ApiStreamObserver<T> {


Unless I'm missing something, I don't see any need for this class to be defined during the execution of this method. Please move the definition outside of the method body (or provide comments explaining why it is defined here, if necessary).

…com/nirupa-kumar/java-docs-samples into microphone-streaming

nnegrey · 2018-06-18T20:03:47Z

Should we push this code into the Recognize.java file?

nirupa-kumar · 2018-06-19T17:12:33Z

Felt adding it in as part of the Recognize.java file made the most sense too. please do let me know which way is best.

nnegrey · 2018-06-22T22:00:49Z

speech/cloud-client/src/main/java/com/example/speech/MicStreamRecognize.java

+/**
+ * Google Cloud SpeechToText API sample application. Example usage: mvn package exec:java
+ * -Dexec.mainClass='com.example.speech.MicStreamRecognize' -Dexec.args="micstreamrecognize
+ * <duration>"


Can use the short version: mvn exec:java -DMicStreamRecognize -Dexec.args="micstreamrecognize <duration>"

nnegrey · 2018-06-22T22:14:24Z

speech/cloud-client/src/test/java/com/example/speech/MicStreamRecognizeIT.java

+
+    @Test
+    public void testMicStreamRecognize() throws Exception {
+        Recognize.streamingRecognizeFile(audioFileName);


Is this testing the above file or just the Recognize.java streaming?

nnegrey · 2018-06-22T22:26:49Z

speech/cloud-client/pom.xml

+      <groupId>com.google.guava</groupId>
+      <artifactId>guava</artifactId>
+      <version>21.0</version>
+    </dependency>


Remove these: 60-75. Seem to be breaking the samples and are not used.

nirupa-kumar · 2018-07-12T15:55:21Z

Will be closing this and re-opening a new one since there have been significant changes to the underlying code.

…2.0 (#1130) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://github.com/GoogleCloudPlatform/cloud-opensource-java)) | `25.1.0` -> `25.2.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/compatibility-slim/25.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/confidence-slim/25.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).

nirupa-kumar and others added 5 commits June 11, 2018 09:43

Add streaming microphone sample for Speech

98530e6

Merge branch 'master' into microphone-streaming

a63462e

Merge branch 'master' of https://github.com/GoogleCloudPlatform/java-…

5cebc15

…docs-samples into microphone-streaming

Merge remote-tracking branch 'remotes/origin/microphone-streaming' in…

c06ea50

…to microphone-streaming

Add streaming microphone sample for Speech - multi-threaded

6d0641e

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 14, 2018

Merge branch 'master' into microphone-streaming

ab9b92a

dzlier-gcp reviewed Jun 18, 2018

View reviewed changes

Merge branches 'master' and 'microphone-streaming' of https://github.…

8cec60d

…com/nirupa-kumar/java-docs-samples into microphone-streaming

beccasaurus assigned beccasaurus and nnegrey and unassigned beccasaurus Jun 18, 2018

nirupa-kumar added 2 commits June 18, 2018 15:32

Fixing as per pull request review comments

2988d29

Fixing as per pull request review comments

1f3c4c1

Merge branch 'master' into microphone-streaming

0651db4

nnegrey reviewed Jun 22, 2018

View reviewed changes

nirupa-kumar closed this Jul 12, 2018

Shabirmean mentioned this pull request Nov 17, 2022

samples: migrate code from googleapis/java-automl #7444

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] Microphone streaming - multi-threaded #1130

[DO NOT MERGE] Microphone streaming - multi-threaded #1130

nirupa-kumar commented Jun 14, 2018

googlebot commented Jun 14, 2018

dzlier-gcp Jun 18, 2018

dzlier-gcp Jun 18, 2018

nnegrey commented Jun 18, 2018

nirupa-kumar commented Jun 19, 2018

nnegrey Jun 22, 2018 •

edited

Loading

nnegrey Jun 22, 2018

nnegrey Jun 22, 2018

nirupa-kumar commented Jul 12, 2018

[DO NOT MERGE] Microphone streaming - multi-threaded #1130

[DO NOT MERGE] Microphone streaming - multi-threaded #1130

Conversation

nirupa-kumar commented Jun 14, 2018

googlebot commented Jun 14, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

dzlier-gcp Jun 18, 2018

Choose a reason for hiding this comment

dzlier-gcp Jun 18, 2018

Choose a reason for hiding this comment

nnegrey commented Jun 18, 2018

nirupa-kumar commented Jun 19, 2018

nnegrey Jun 22, 2018 • edited Loading

Choose a reason for hiding this comment

nnegrey Jun 22, 2018

Choose a reason for hiding this comment

nnegrey Jun 22, 2018

Choose a reason for hiding this comment

nirupa-kumar commented Jul 12, 2018

nnegrey Jun 22, 2018 •

edited

Loading