Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java code sample for concepts-infotypes #3012

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Add Java code sample for concepts-infotypes #3012

merged 1 commit into from
Jun 2, 2020

Conversation

jakubrauch
Copy link
Contributor

https://cloud.google.com/dlp/docs/concepts-infotypes

Fixes

It's a good idea to open an issue first for discussion.

  • [yes, except where consistency made more sense] I have followed Sample Format Guide
  • [yes] pom.xml parent set to latest shared-configuration
  • [yes] Appropriate changes to README are included in PR
  • [nothing new] API's need to be enabled to test (tell us)
  • [nothing new] Environment Variables need to be set (ask us to set them)
  • [yes] Tests pass (mvn -P lint clean verify)
    • (Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)
  • [yes] Please merge this PR for me once it is approved.

@jakubrauch jakubrauch requested a review from a team June 2, 2020 00:56
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2020
gguuss
gguuss approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lesv lesv merged commit 7cc9546 into GoogleCloudPlatform:master Jun 2, 2020
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
@jakubrauch @chingor13
samples: Add Java code sample for concepts-infotypes (#3012)
d3dae62 
https://cloud.google.com/dlp/docs/concepts-infotypes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss approved these changes

Assignees

@gguuss gguuss

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakubrauch @gguuss @lesv @googlebot