Update Google Credentials #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lesv
approved these changes
Jun 2, 2020
lesv
approved these changes
Jun 2, 2020
| /** Set the path of the OS image for the sample VM instance to be created. */ | ||
| private static final String SOURCE_IMAGE_PREFIX = | ||
| "https://www.googleapis.com/compute/v1/projects/"; | ||
|
|
||
| private static final String SOURCE_IMAGE_PATH = | ||
| "debian-cloud/global/images/debian-7-wheezy-v20150710"; |
Comment on lines
167
to
171
| "https://www.googleapis.com/compute/v1/projects/" | ||
| + PROJECT_ID + "/zones/" + ZONE_NAME + "/machineTypes/n1-standard-1"); | ||
| + PROJECT_ID | ||
| + "/zones/" | ||
| + ZONE_NAME | ||
| + "/machineTypes/n1-standard-1"); |
There was a problem hiding this comment.
Perhaps we could create this string w/ String.format(...) Also, we should probably use e2-standard-1 as well.
Comment on lines
176
to
178
| "https://www.googleapis.com/compute/v1/projects/" | ||
| + PROJECT_ID | ||
| + "/global/networks/default"); |
Comment on lines
199
to
203
| "https://www.googleapis.com/compute/v1/projects/" | ||
| + PROJECT_ID | ||
| + "/zones/" | ||
| + ZONE_NAME | ||
| + "/diskTypes/pd-standard"); |
| @@ -208,7 +220,8 @@ public static Operation startInstance(Compute compute, String instanceName) thro | |||
| // If you put a script called "vm-startup.sh" in this Google Cloud Storage | |||
| // bucket, it will execute on VM startup. This assumes you've created a | |||
| // bucket named the same as your PROJECT_ID. | |||
| // For info on creating buckets see: https://cloud.google.com/storage/docs/cloud-console#_creatingbuckets | |||
| // For info on creating buckets see: | |||
| // https://cloud.google.com/storage/docs/cloud-console#_creatingbuckets | |||
| item.setValue("gs://" + PROJECT_ID + "/vm-startup.sh"); | |||
Comment on lines
38
to
45
| * <p>- Create job within batch | ||
| * | ||
| * - Update job within batch | ||
| * <p>- Update job within batch | ||
| * | ||
| * - Delete job within batch. | ||
| * <p>- Delete job within batch. | ||
| * | ||
| * For simplicity, the samples always use the same kind of requests in each batch. In a real case , | ||
| * you might put different kinds of request in one batch. | ||
| * <p>For simplicity, the samples always use the same kind of requests in each batch. In a real case | ||
| * , you might put different kinds of request in one batch. |
Comment on lines
37
to
39
| * <p>- Construct a Job with CustomAttribute | ||
| * | ||
| * - Search Job with CustomAttributeFilter | ||
| * <p>- Search Job with CustomAttributeFilter |
Comment on lines
29
to
31
| * <p>- Default auto complete (on both company display name and job title) | ||
| * | ||
| * - Auto complete on job title only | ||
| * <p>- Auto complete on job title only |
Comment on lines
29
to
39
| * <p>- Construct a company with required fields | ||
| * | ||
| * - Create a company | ||
| * <p>- Create a company | ||
| * | ||
| * - Get a company | ||
| * <p>- Get a company | ||
| * | ||
| * - Update a company | ||
| * <p>- Update a company | ||
| * | ||
| * - Update a company with field mask | ||
| * <p>- Update a company with field mask | ||
| * | ||
| * - Delete a company | ||
| * <p>- Delete a company |
Comment on lines
32
to
43
| * <p>- Construct a job with required fields | ||
| * | ||
| * - Create a job | ||
| * <p>- Create a job | ||
| * | ||
| * - Get a job | ||
| * <p>- Get a job | ||
| * | ||
| * - Update a job | ||
| * <p>- Update a job | ||
| * | ||
| * - Update a job with field mask | ||
| * <p>- Update a job with field mask | ||
| * | ||
| * - Delete a job | ||
| * <p>- Delete a job | ||
| */ |
lesv
approved these changes
Jun 2, 2020
averikitsch
added
the
automerge
jakubrauch
pushed a commit
to jakubrauch/java-docs-samples
that referenced
this pull request
Jun 4, 2020
* Update credentials * lint * Update accesstoken * lint * remove <p> * Use String.format * lint * Update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2885
pom.xmlparent set to latestshared-configurationmvn -P lint clean verify)Checkstylepassing is required;Spotbugs,ErrorProne,PMD, etc.ERROR's are advisory only)