Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include different ways to delete data in sample #3034

Merged

Conversation

olavloite
Copy link
Contributor

Fixes #3033

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass (mvn -P lint clean verify)
    • (Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)
  • Please merge this PR for me once it is approved.

@olavloite olavloite requested a review from a team June 3, 2020 09:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 3, 2020
@olavloite olavloite requested a review from skuruppu June 3, 2020 12:33
@olavloite
Copy link
Contributor Author

@lesv Would you mind merging this PR? I am not authorized to do so.

@kurtisvg kurtisvg merged commit f00cbef into GoogleCloudPlatform:master Jun 4, 2020
jakubrauch pushed a commit to jakubrauch/java-docs-samples that referenced this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the spanner_delete_data code sample to have examples for all the delete methods
5 participants