Fix DLP inspect tests to fail on timeout #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
gguuss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
lesv
approved these changes
Jun 4, 2020
| } | ||
|
|
||
| @Test | ||
| public void testInspectDatastoreEntity() | ||
| throws InterruptedException, ExecutionException, IOException { | ||
| public void testInspectDatastoreEntity() throws Exception { |
There was a problem hiding this comment.
Why did you reduce the throws here?
There was a problem hiding this comment.
- It seemed unnecessarily verbose.
- I was trying to follow the guidance in https://engdoc.corp.google.com/eng/doc/devguide/java/practices/exceptions.md?cl=head#test_methods.
- Tests are currently inconsistent in how they handle this but given the above, I wanted to move towards the simpler
throws Exception.
stephaniewang526
approved these changes
Jun 4, 2020
sushicw
force-pushed
the
fix-tests_b-158026949
branch
from
0f58e94 to
33a6701
Compare
kokoro-team
removed
the
kokoro:run
kurtisvg
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
lesv
added
the
automerge
kurtisvg
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
kurtisvg
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update DLP inspect tests to fail properly, instead of timing out after 15 minutes and passing.
Also remove some broken code that tried to cancel early.
Fixes internal bug b/158026949
pom.xmlparent set to latestshared-configurationmvn -P lint clean verify)Checkstylepassing is required;Spotbugs,ErrorProne,PMD, etc.ERROR's are advisory only)