Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add region tags for Spanner JDBC samples #3052

Merged
merged 3 commits into from
Jun 4, 2020
Merged

chore: add region tags for Spanner JDBC samples #3052

merged 3 commits into from
Jun 4, 2020

Conversation

skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jun 4, 2020 •
edited
Loading

Currently the public docs don't point to the samples on GitHub so adding the relevant region tags here to enable the docs to point to these samples.

Also made changes to the following samples to match those of the existing samples:

  • InsertDataExample.java to use autocommit to be equivalent to existing sample.
  • BatchDmlExample.java to turn off autocommit to be equivalent to existing sample.

If the changes in 3d5e615 don't make sense, happy to revert.

@skuruppu skuruppu added the api: spanner Issues related to the Spanner API. label Jun 4, 2020
@skuruppu skuruppu requested review from olavloite and a team June 4, 2020 04:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2020
@skuruppu
Copy link
Contributor Author

skuruppu commented Jun 4, 2020

I will take a look at the CI failures in a few hours when I come back online. Sorry about that. Feel free to ignore the PR until I fix it.

@skuruppu skuruppu force-pushed the spanner-jdbc-sample-region-tags branch from 3d5e615 to 3d36acc Compare June 4, 2020 10:38
@skuruppu
Copy link
Contributor Author

skuruppu commented Jun 4, 2020

@lesv or @kurtisvg, I will need your help to merge this in as I don't have the permissions :)

@kurtisvg kurtisvg added the automerge Merge the pull request once unit tests and other checks pass. label Jun 4, 2020
@kurtisvg kurtisvg merged commit 23e02c5 into GoogleCloudPlatform:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@olavloite olavloite olavloite approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
api: spanner Issues related to the Spanner API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skuruppu @lesv @olavloite @kurtisvg @googlebot