Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Java code sample for omit domain names that are an email #3066

Conversation

sushicw
Copy link
Contributor

@sushicw sushicw commented Jun 5, 2020

Fixes internal bug b/156972858

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us) (Nothing new)
  • Environment Variables need to be set (ask us to set them) (Nothing new)
  • Tests pass (mvn -P lint clean verify)
    • (Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)
  • Please merge this PR for me once it is approved.

@sushicw sushicw requested a review from a team June 5, 2020 17:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2020
@lesv lesv added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jun 5, 2020
@sushicw sushicw force-pushed the inspect-omit-domain-overlap_b-156972858 branch from 59ff6ae to ca9b5d9 Compare June 5, 2020 18:41
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@lesv lesv added the automerge Merge the pull request once unit tests and other checks pass. label Jun 5, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit b4d608a into GoogleCloudPlatform:master Jun 5, 2020
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
…ail (#3066)

Fixes internal bug b/156972858

- [X] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md)
- [X] `pom.xml` parent set to latest `shared-configuration`
- [X] Appropriate changes to README are included in PR
- [X] API's need to be enabled to test (tell us) (**Nothing new**)
- [X] Environment Variables need to be set (ask us to set them) (**Nothing new**)
- [X] Tests pass (`mvn -P lint clean verify`)
  * (Note- `Checkstyle` passing is required; `Spotbugs`, `ErrorProne`, `PMD`, etc. `ERROR`'s are advisory only)
- [X] Please **merge** this PR for me once it is approved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants