Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "compile" goal to static check #3116

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Add "compile" goal to static check #3116

merged 1 commit into from
Jun 10, 2020

Conversation

kurtisvg
Copy link
Contributor

  • Adds "compile" for errorprone + spotbugs to work.
  • Removes lint profile from main tests

FYI: Spotbugs will show errors, but will continue to pass until java-repo-tools is updated.

@kurtisvg kurtisvg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 10, 2020
@kurtisvg kurtisvg requested review from lesv and a team June 10, 2020 00:08
@kurtisvg kurtisvg self-assigned this Jun 10, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2020
@kurtisvg kurtisvg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 10, 2020
@kurtisvg kurtisvg merged commit 9f4bf09 into master Jun 10, 2020
@kurtisvg kurtisvg deleted the lint-fix branch June 10, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurtisvg @lesv @googlebot