Create Java code sample for wordList example - Exception list #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
The test failure seems to be caused by a flaky test, looks unrelated to this change: [ERROR] Tests run: 20, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 2,347.024 s <<< FAILURE! - in dlp.snippets.InspectTests Expected: a string containing "Job status: DONE" |
averikitsch
approved these changes
Jun 10, 2020
averikitsch
added
automerge
kokoro-team
removed
the
kokoro:force-run
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
#3120) To be linked from https://cloud.google.com/dlp/docs/creating-custom-infotypes-dictionary#exception_list Fixes #issue It's a good idea to open an issue first for discussion. [yes] I have followed Sample Format Guide [yes] pom.xml parent set to latest shared-configuration [nothing new] Appropriate changes to README are included in PR [nothing new] API's need to be enabled to test (tell us) [nothing new] Environment Variables need to be set (ask us to set them) [yes] Tests pass (mvn -P lint clean verify) (Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only) [yes] Please merge this PR for me once it is approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be linked from https://cloud.google.com/dlp/docs/creating-custom-infotypes-dictionary#exception_list
Fixes #issue
It's a good idea to open an issue first for discussion.
[yes] I have followed Sample Format Guide
[yes] pom.xml parent set to latest shared-configuration
[nothing new] Appropriate changes to README are included in PR
[nothing new] API's need to be enabled to test (tell us)
[nothing new] Environment Variables need to be set (ask us to set them)
[yes] Tests pass (mvn -P lint clean verify)
(Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)
[yes] Please merge this PR for me once it is approved.