Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template #3131

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Update PR template #3131

merged 1 commit into from
Jun 10, 2020

Conversation

lesv
Copy link
Contributor

@lesv lesv commented Jun 10, 2020

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass (mvn -P lint clean verify)
    • (Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)
  • Please merge this PR for me once it is approved.

@lesv lesv requested review from kurtisvg and a team June 10, 2020 21:36
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2020
@lesv lesv added the automerge Merge the pull request once unit tests and other checks pass. label Jun 10, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8327451 into master Jun 10, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the lesv-patch-1 branch June 10, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lesv @kurtisvg @googlebot @dzlier-gcp