Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some ProjectName uses in DLP #3166

Merged

Conversation

sushicw
Copy link
Contributor

@sushicw sushicw commented Jun 12, 2020

Clean up some samples that got added with the old way of setting the parent field. See internal bug b/158100365 for context.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@sushicw sushicw requested a review from a team June 12, 2020 21:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2020
@lesv lesv added the automerge Merge the pull request once unit tests and other checks pass. label Jun 12, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@lesv lesv added kokoro:run Add this label to force Kokoro to re-run the tests. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jun 13, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 13, 2020
@lesv lesv added the automerge Merge the pull request once unit tests and other checks pass. label Jun 13, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8378c67 into GoogleCloudPlatform:master Jun 13, 2020
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
Clean up some samples that got added with the old way of setting the parent field. See internal bug b/158100365 for context.

- [X] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md)
- [X] `pom.xml` parent set to latest `shared-configuration`
- [X] Appropriate changes to README are included in PR
- [X] API's need to be enabled to test (tell us)
- [X] Environment Variables need to be set (ask us to set them)
- [X] **Tests** pass:   `mvn clean verify` **required**
- [X] **Lint**  passes: `mvn -P lint checkstyle:check` **required**
- [X] **Static Analysis**:  `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only**
- [X] Please **merge** this PR for me once it is approved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants