Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lint check to use Java 11 image. #3192

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Update lint check to use Java 11 image. #3192

merged 1 commit into from
Jun 17, 2020

Conversation

kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Jun 17, 2020 •
edited
Loading

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@kurtisvg kurtisvg requested review from lesv and a team June 17, 2020 20:49
@kurtisvg kurtisvg self-assigned this Jun 17, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 17, 2020
@kurtisvg kurtisvg added the automerge Merge the pull request once unit tests and other checks pass. label Jun 17, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 946039b into master Jun 17, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the kurtisvg-patch-1 branch June 17, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@kurtisvg kurtisvg

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurtisvg @lesv @googlebot