Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to BOM 7 #3203

Merged
merged 2 commits into from
Jun 18, 2020
Merged

update to BOM 7 #3203

merged 2 commits into from
Jun 18, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jun 18, 2020

@lesv since these are separate projects in the same repo, more granular PRs will help isolate issues

@elharo elharo requested a review from a team June 18, 2020 12:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2020
@elharo
Copy link
Contributor Author

elharo commented Jun 18, 2020

appengine-java11/guestbook-cloud-firestore

[ERROR] Failed to execute goal on project guestbook-cloud-firestore: Could not resolve dependencies for project com.example.guestbook:guestbook-cloud-firestore:war:1.0-SNAPSHOT: Could not find artifact com.example.appengine.demo:simple-jetty-main:jar:1 in central (https://repo.maven.apache.org/maven2) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]

@elharo
Copy link
Contributor Author

elharo commented Jun 18, 2020

Looks like this dependency needs to be published to Maven central; either that or reconfigure the static analysis Kokoro job to install it:

    <dependency>
      <groupId>com.example.appengine.demo</groupId>
      <artifactId>simple-jetty-main</artifactId>
      <version>1</version>
      <scope>provided</scope>
    </dependency>

@lesv
Copy link
Contributor

lesv commented Jun 18, 2020

@averikitsch FYI

@lesv lesv merged commit bde9a05 into master Jun 18, 2020
@lesv lesv deleted the firestore branch June 18, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants