Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sample code for Cloud Assets Inventory ListAssets v1p5beta1 APIs. #3408

Merged
merged 4 commits into from
Jul 31, 2020
Merged

Add sample code for Cloud Assets Inventory ListAssets v1p5beta1 APIs. #3408

merged 4 commits into from
Jul 31, 2020

Conversation

Larittic-GG
Copy link
Contributor

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@Larittic-GG Larittic-GG requested a review from a team July 24, 2020 06:45
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2020
lesv
lesv suggested changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the Sample Format guide.

@lesv lesv added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 24, 2020
@lesv
Copy link
Contributor

lesv commented Jul 24, 2020

To be specific, samples are typically follow this form.

@Larittic-GG
Copy link
Contributor Author

To be specific, samples are typically follow this form.

Thanks for pointing out the direction! 👍 I've revamped the code accordingly. Initially I was following example code with out-dated style as it turned out :)

@lesv lesv merged commit e7fd111 into GoogleCloudPlatform:master Jul 31, 2020
minherz pushed a commit that referenced this pull request Nov 16, 2022
@Larittic-GG @chingor13
samples: Add sample code for Cloud Assets Inventory ListAssets v1p5be…
8976d18 
…ta1 APIs. (#3408)

* Add sample code for Cloud Assets Inventory ListAssets v1p5beta1 APIs.

* Fix lint.

* Revamped according to style guide.

* Add a missing function call in listAssets().
minherz pushed a commit that referenced this pull request Nov 17, 2022
@Larittic-GG @minherz
samples: Add sample code for Cloud Assets Inventory ListAssets v1p5be…
ace11d8 
…ta1 APIs. (#3408)

* Add sample code for Cloud Assets Inventory ListAssets v1p5beta1 APIs.

* Fix lint.

* Revamped according to style guide.

* Add a missing function call in listAssets().
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
@Larittic-GG @anguillanneuf
samples: Add sample code for Cloud Assets Inventory ListAssets v1p5be…
b37d5eb 
…ta1 APIs. (#3408)

* Add sample code for Cloud Assets Inventory ListAssets v1p5beta1 APIs.

* Fix lint.

* Revamped according to style guide.

* Add a missing function call in listAssets().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Larittic-GG @lesv @dzlier-gcp