Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github.com/GoogleCloudPlatform/k8s-cloud-provider]:upgrade k8s.io/klog/v2 #37

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

tanjunchen
Copy link
Contributor

[github.com/GoogleCloudPlatform/k8s-cloud-provider]:upgrade k8s.io/klog/v2
ref:kubernetes/kubernetes#89961

go.mod Outdated
@@ -9,7 +9,7 @@ require (
golang.org/x/sys v0.0.0-20200116001909-b77594299b42 // indirect
google.golang.org/api v0.15.1-0.20200106000736-b8fc810ca6b5
google.golang.org/genproto v0.0.0-20200115191322-ca5a22157cba // indirect
k8s.io/klog v1.0.0
k8s.io/klog/v2 v2.0.0-rc.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to v2.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure . Thanks

go.mod Outdated
@@ -9,7 +9,7 @@ require (
golang.org/x/sys v0.0.0-20200116001909-b77594299b42 // indirect
google.golang.org/api v0.15.1-0.20200106000736-b8fc810ca6b5
google.golang.org/genproto v0.0.0-20200115191322-ca5a22157cba // indirect
k8s.io/klog v1.0.0
k8s.io/klog/v2 v2.0.0-rc.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to v2.0.0

@serathius
Copy link

cc @bowei

@dims
Copy link
Contributor

dims commented Apr 13, 2020

cc @rramkumar1

@bowei
Copy link
Member

bowei commented Apr 14, 2020

@spencerhance can you take a look

@bowei bowei merged commit e05e318 into GoogleCloudPlatform:master Apr 14, 2020
@tanjunchen tanjunchen deleted the patch-01 branch April 14, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants