Set nil cache for NoCacheClientFunc

GoogleCloudPlatform · Dec 9, 2023 · ca0afaf · ca0afaf
1 parent cce2c90
commit ca0afaf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/operator/pkg/preflight/upgrade_test.go b/operator/pkg/preflight/upgrade_test.go
@@ -218,11 +218,6 @@ func TestUpgradeChecker_Preflight(t *testing.T) {
 			repo := FakeRepo{
 				channel: tc.channel,
 			}
-			// Adding the wait to avoid the error "the cache is not started, can
-			// not read objects".
-			if !mgr.GetCache().WaitForCacheSync(ctx) {
-				t.Fatalf("the cache in the test manager did not sync")
-			}
 			u := NewUpgradeChecker(client, &repo)
 			err := u.Preflight(ctx, tc.cc)
 			asserts.AssertErrorIsExpected(t, err, tc.err)

diff --git a/pkg/controller/kccmanager/nocache/clientbuilder.go b/pkg/controller/kccmanager/nocache/clientbuilder.go
@@ -20,5 +20,6 @@ import (
 )
 
 var NoCacheClientFunc = func(config *rest.Config, options client.Options) (client.Client, error) {
+	options.Cache = nil
 	return client.New(config, options)
 }