mockgcp: add support for TagsTagBinding #1918
Conversation
justinsb
commented
May 31, 2024
justinsb
commented
- mockgcp: add support for TagsTagBinding
- chore: capture golden output for some tag tests
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
force-pushed
the
tagstagbinding_simplified
branch
from
3027c92
to
4cd1934
Compare
justinsb
force-pushed
the
tagstagbinding_simplified
branch
from
4cd1934
to
fe71af3
Compare
| err := wait.PollImmediate(1*time.Second, 35*time.Minute, func() (done bool, err error) { | ||
| done = true | ||
| logger.V(2).Info("Testing to see if resource is ready", "kind", u.GetKind(), "name", u.GetName()) |
There was a problem hiding this comment.
here and below for samples.go -- do we want to disassociate the logs? Thinking that it may be irrelevant for whne running a single test but maybe useful for when running multiple?
There was a problem hiding this comment.
What do you mean by "disassociate the logs" ?
There was a problem hiding this comment.
(If you mean "why did we stop adding the values, it's because we add them to the logger above:
logger := log.FromContext(t.Ctx).WithValues("kind", gvk.Kind, "name", id.Name)
)
| # TODO: projectId should work | ||
| external: //cloudresourcemanager.googleapis.com/projects/${projectNumber} |
There was a problem hiding this comment.
I may have lost state on this question, but are we going to make project-${uniquedId} work as a follow on or test that it works as a follow on?
There was a problem hiding this comment.
Yes, I think we should make it work when we have a direct actuation implementation!
justinsb
force-pushed
the
tagstagbinding_simplified
branch
from
e7f50a3
to
f5a9777
Compare
Co-authored-by: alex <8968914+acpana@users.noreply.github.com>
justinsb
force-pushed
the
tagstagbinding_simplified
branch
from
f5a9777
to
b2e7fc5
Compare
