-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golden output of gkehub resource with IAM references #2120
Add golden output of gkehub resource with IAM references #2120
Conversation
/assign @justinsb When we turn on the feature flag to use the new controller, the test should cover the code logic in the above PR. |
tests/e2e/testdata/scenarios/gkehubfeaturemembership/iam_test/script.yaml
Outdated
Show resolved
Hide resolved
5640488
to
2f950af
Compare
cd23790
to
a23e380
Compare
/hold for further discussing the changes around |
0e84b85
to
bf7d845
Compare
/unhold, Hey @yuwenma , this PR doesn't change |
bf7d845
to
e800447
Compare
e800447
to
355ba06
Compare
355ba06
to
cdc12d1
Compare
cdc12d1
to
775b50a
Compare
The test failure seems to be unrelated to my change
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
931f3cc
into
GoogleCloudPlatform:master
Change description
Add golden output of gkehub resource with IAM references
Tests you have done
make ready-pr
to ensure this PR is ready for review.