chore: generate CRD for KMSCryptoKey #2195
Conversation
justinsb
force-pushed
the
crd_for_kmscryptokey
branch
2 times, most recently
from
22665c3
to
0533416
Compare
justinsb
changed the title
justinsb
force-pushed
the
crd_for_kmscryptokey
branch
from
0533416
to
94429a4
Compare
|
Added! |
justinsb
force-pushed
the
crd_for_kmscryptokey
branch
2 times, most recently
from
7f4745a
to
fad45f6
Compare
justinsb
force-pushed
the
crd_for_kmscryptokey
branch
from
fad45f6
to
77eab39
Compare
| /* The `name` field of a `KMSKeyRing` resource. */ | ||
| Name string `json:"name,omitempty"` | ||
| /* The `namespace` field of a `KMSKeyRing` resource. */ | ||
| Namespace string `json:"namespace,omitempty"` |
There was a problem hiding this comment.
(I shall ask this earlier) What's the (current) plan if this references to a different namespace?
There was a problem hiding this comment.
Not sure ... we will attempt to read it. The customer can use RBAC to prevent this access (in Namespace mode). But in general, it should just work.
apis/refs/v1beta1/kmskeyringref.go
Outdated
|
|
||
| if ref.External != "" { | ||
| tokens := strings.Split(ref.External, "/") | ||
| if len(tokens) == 6 && tokens[0] == "project" && tokens[2] == "locations" && tokens[4] == "keyRings" { |
There was a problem hiding this comment.
"projects": missing "s" in tokens[0] == "project"
There was a problem hiding this comment.
Great spot - thank you!
|
Thanks for the review @yuwenma - and for spotting project vs projects :-) Given our new 3 or 4 step process (1a CRD 1b Mappers & Round-Trip Tests 2 Controller and realgcp test 3 mockgcp and tests work there also), I think I will try to get this to 1b ... mappers & a round-trip test! |
justinsb
force-pushed
the
crd_for_kmscryptokey
branch
4 times, most recently
from
4c03f2b
to
37a6e64
Compare
justinsb
force-pushed
the
crd_for_kmscryptokey
branch
from
37a6e64
to
b410a90
Compare
|
/lgtm Not sure about the presubmit failure. (could be just a rebase thing) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chore: generate CRD for KMSCryptoKey