-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO_NOT_MERGE golden from real gcp #2269
base: master
Are you sure you want to change the base?
DO_NOT_MERGE golden from real gcp #2269
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @yuwenma |
@@ -20,15 +20,14 @@ spec: | |||
membershipRef: | |||
name: gkehubmembership-mesh-${uniqueId} | |||
mesh: | |||
controlPlane: CONTROL_PLANE_MANAGEMENT_UNSPECIFIED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this is what i"m looking for. In pkg/test/resourcefixture/testdata/basic/gkehub/v1beta1/gkehubfeaturemembership/meshgkehubfeaturemembership/_generated_object_meshgkehubfeaturemembership.golden.yaml the mesh.controlPlane was removed. Maybe because the previous golden object was not correctly generated?
c0be2c9
to
2aa2344
Compare
2aa2344
to
08bd5a2
Compare
/hold |
Change description
output from hack/record-gcp fixtures/meshgkehubfeaturemembership
Tests you have done
make ready-pr
to ensure this PR is ready for review.