Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO_NOT_MERGE golden from real gcp #2269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DO_NOT_MERGE golden from real gcp #2269

wants to merge 1 commit into from

Conversation

ziyue-101
Copy link
Collaborator

@ziyue-101 ziyue-101 commented Jul 10, 2024 •
edited

Change description

output from hack/record-gcp fixtures/meshgkehubfeaturemembership

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ziyue-101. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ziyue-101
Copy link
Collaborator Author

/cc @yuwenma

@google-oss-prow google-oss-prow bot requested a review from yuwenma July 10, 2024 21:57
yuwenma
yuwenma reviewed Jul 10, 2024
View reviewed changes
...ership/meshgkehubfeaturemembership/_generated_object_meshgkehubfeaturemembership.golden.yaml
@@ -20,15 +20,14 @@ spec:
membershipRef:
name: gkehubmembership-mesh-${uniqueId}
mesh:
controlPlane: CONTROL_PLANE_MANAGEMENT_UNSPECIFIED
Copy link
Collaborator

@yuwenma yuwenma Jul 10, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this is what i"m looking for. In pkg/test/resourcefixture/testdata/basic/gkehub/v1beta1/gkehubfeaturemembership/meshgkehubfeaturemembership/_generated_object_meshgkehubfeaturemembership.golden.yaml the mesh.controlPlane was removed. Maybe because the previous golden object was not correctly generated?

@ziyue-101
Copy link
Collaborator Author

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenma yuwenma yuwenma left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ziyue-101 @yuwenma