Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: factor out maputils #2278

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

acpana
Copy link
Collaborator

@acpana acpana commented Jul 11, 2024

Proof of concept of sharing the map utils and other utils across all the direct package.

@acpana
Copy link
Collaborator Author

acpana commented Jul 11, 2024

/hold

A few more places that can be factored out if this is something we want to do!

@yuwenma
Copy link
Collaborator

yuwenma commented Jul 11, 2024

Actually I think we shall move the cbwp mapping to the direct controller dir (but since we are still developing the mapper tool, this may not be done anyways 😆 ).

@acpana
Copy link
Collaborator Author

acpana commented Jul 11, 2024

I don't mind taking on the tooling changes for this too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think it makes sense to do this now as we are starting to add more resources as opposed to doing it later.

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acpana
Copy link
Collaborator Author

acpana commented Jul 17, 2024

/hold cancel

can follow up in more places to factor out and make template changes

@google-oss-prow google-oss-prow bot merged commit 2e3ea62 into GoogleCloudPlatform:master Jul 17, 2024
13 checks passed
@acpana acpana mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants