-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: factor out maputils #2278
refactor: factor out maputils #2278
Conversation
/hold A few more places that can be factored out if this is something we want to do! |
Actually I think we shall move the cbwp mapping to the direct controller dir (but since we are still developing the mapper tool, this may not be done anyways 😆 ). |
I don't mind taking on the tooling changes for this too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think it makes sense to do this now as we are starting to add more resources as opposed to doing it later.
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel can follow up in more places to factor out and make template changes |
2e3ea62
into
GoogleCloudPlatform:master
Proof of concept of sharing the map utils and other utils across all the
direct
package.