Compositions [feat] Remove hardcoded values and parameterize AppTeam sample #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoweim
reviewed
Jul 17, 2024
|
/lgtm |
|
/approve |
barney-s
force-pushed
the
fix_appteam
branch
3 times, most recently
from
a2810fa
to
d5034b6
Compare
- Parameterize hardcoded project and billing account - Parameterize admin user - Move from facade.facade to idp.mycompany.com group - Remove Role and ClusterRole binding since it should not be needed for now. - correct get_appteam.sh script to get the right appteam
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, xiaoweim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit f5e51f8
into
GoogleCloudPlatform:master
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Remove hardcoded values from the AppTeam sample.
Parameterize the additional fields.