feat: direct dataformrepository ctrl #2283
Conversation
acpana
force-pushed
the
acpana/dataform-direct-ctrl
branch
4 times, most recently
from
65f18f3
to
6435d03
Compare
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
acpana
force-pushed
the
acpana/dataform-direct-ctrl
branch
from
6435d03
to
448a74d
Compare
| return fmt.Sprintf("projects/%s/locations/%s", a.projectID, a.location) | ||
| } | ||
|
|
||
| func setStatus(u *unstructured.Unstructured, typedStatus any) error { |
There was a problem hiding this comment.
If it's alpha (and therefore uses observedState) we might actually use a different helper setObservedState; it's a much simpler function to write
There was a problem hiding this comment.
Is it ok if I follow up here? There's a few changes to the API that are needed for the beta promotion and there's no ObservedState yet in the Status. I can add it with the other API changes.
|
LGTM. Only blocker is whether we can do something better than string matching against the error |
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
acpana
force-pushed
the
acpana/dataform-direct-ctrl
branch
from
448a74d
to
edb09e7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add
directcontroller forDataformRepository.