-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: direct dataformrepository ctrl #2283
Conversation
65f18f3
to
6435d03
Compare
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
6435d03
to
448a74d
Compare
return fmt.Sprintf("projects/%s/locations/%s", a.projectID, a.location) | ||
} | ||
|
||
func setStatus(u *unstructured.Unstructured, typedStatus any) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's alpha (and therefore uses observedState) we might actually use a different helper setObservedState
; it's a much simpler function to write
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok if I follow up here? There's a few changes to the API that are needed for the beta promotion and there's no ObservedState yet in the Status. I can add it with the other API changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course!
LGTM. Only blocker is whether we can do something better than string matching against the error |
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
448a74d
to
edb09e7
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add
direct
controller forDataformRepository
.