mockgcp: more fidelity/tests for ComputeNetwork with autoCreateSubnets #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justinsb
commented
Jul 16, 2024
justinsb
commented
- mockgcp: fidelity for ComputeNetworks with autoCreateSubnets
- tests: create test for ComputeNetwork with autoCreateSubnets=true
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
force-pushed
the
mockgcp_fidelity_networking_1
branch
from
09415d5
to
090f2d7
Compare
justinsb
force-pushed
the
mockgcp_fidelity_networking_1
branch
from
090f2d7
to
f012ec8
Compare
Some changes to response normalization.
We were only normalizing a handful of the URLs from the compute requests.
justinsb
force-pushed
the
mockgcp_fidelity_networking_1
branch
from
f012ec8
to
dc87bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.