mockgcp: add comments to protos generated from OpenAPI #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheftako
reviewed
Jul 17, 2024
| // serviceID := c.doc.Name | ||
| // prefix := []string{"google", "cloud"} | ||
|
|
||
| tokens := strings.Split(c.protoPackageName, ".") |
There was a problem hiding this comment.
Should probably check the tokens is the expected length.
There was a problem hiding this comment.
Good call - done!
There was a problem hiding this comment.
If its more than 2 doesn't that also suggest we may be splitting it incorrectly?
|
/lgtm |
justinsb
force-pushed
the
gapic_add_comments
branch
from
8e5d58f
to
bfe519e
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 9975a63
into
GoogleCloudPlatform:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.