-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mockgcp: add comments to protos generated from OpenAPI #2299
mockgcp: add comments to protos generated from OpenAPI #2299
Conversation
// serviceID := c.doc.Name | ||
// prefix := []string{"google", "cloud"} | ||
|
||
tokens := strings.Split(c.protoPackageName, ".") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably check the tokens is the expected length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call - done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If its more than 2 doesn't that also suggest we may be splitting it incorrectly?
/lgtm |
8e5d58f
to
bfe519e
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9975a63
into
GoogleCloudPlatform:master
No description provided.