tools: auto insert the generated field and messaged from a new proto field #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyih
force-pushed
the
insert_field
branch
2 times, most recently
from
8073bb4
to
570dc6f
Compare
|
How do we fix merge conflict on go.work? @yuwenma |
jingyih
force-pushed
the
insert_field
branch
4 times, most recently
from
b7c1cc8
to
a5f2c13
Compare
|
/assign @jasonvigil @justinsb |
jasonvigil
reviewed
Aug 27, 2024
| ast.Inspect(file, func(n ast.Node) bool { | ||
| switch node := n.(type) { | ||
| case *ast.GenDecl: | ||
| if node.Tok != token.TYPE || len(node.Specs) == 0 { |
There was a problem hiding this comment.
It looks like || len(node.Specs) == 0 is unnecessary?
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasonvigil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jingyih
force-pushed
the
insert_field
branch
from
a5f2c13
to
f5e9cc0
Compare
revert changes made by the update tool. update go mod.
|
Rebased |
|
/lgtm |
google-oss-prow
bot
merged commit 1ed7c14
into
GoogleCloudPlatform:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The insertion is mechanical, based on go file parsing.
This PR is rebased on #2425, which is AI-based inseration.
Future work: