Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mockgcp: support for PubSubSubscription #2529

Merged
merged 3 commits into from
Aug 27, 2024
Merged

mockgcp: support for PubSubSubscription #2529

merged 3 commits into from
Aug 27, 2024

Conversation

justinsb
Copy link
Collaborator

  • tests: capture golden output for PubSub
  • mockgcp: support for PubSubSubscription

@justinsb justinsb force-pushed the pubsub_fidelity branch 3 times, most recently from 07a88cd to de49704 Compare August 24, 2024 14:53
yuwenma
yuwenma reviewed Aug 24, 2024
View reviewed changes
mockgcp/mockpubsub/topic.go
"us-west4",
"us-west8",
},
// TODO: When _is_ this populated?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I don't know, but at least in PubSubTopic creation. (I verified against real GCP in the mock storage notification #2447)

yuwenma
yuwenma reviewed Aug 24, 2024
View reviewed changes
...fixture/testdata/basic/storage/v1beta1/storagenotification/storagenotificationbase/_http.log Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real GCP populates the messageStoragePolicy in these 2 test suites for storage notification. (The pubSubTopic is a dependency which calls the create method )

yuwenma
yuwenma reviewed Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@yuwenma yuwenma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
you may want to update the populate MessageStorageePolicy for PubSubTopic create (at least).

@google-oss-prow google-oss-prow bot added the lgtm label Aug 24, 2024
@yuwenma
Copy link
Collaborator

yuwenma commented Aug 24, 2024

/approve
/hold

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Aug 26, 2024
@yuwenma
Copy link
Collaborator

yuwenma commented Aug 27, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 27, 2024
@justinsb
Copy link
Collaborator Author

I still haven't found any GCP APIs that are returning the message storage policy... might be an API change. We should detect it with our e2e tests anyway...

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 396428b into GoogleCloudPlatform:master Aug 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenma yuwenma yuwenma left review comments

Assignees

@yuwenma yuwenma

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinsb @yuwenma