Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CEL-based validation rules for SQLInstance #2558

Closed

Conversation

jasonvigil
Copy link
Collaborator

Change description

  • OneOf for password values
  • Immutable for CloneSource

Depends on #2429

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jasonvigil. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jasonvigil
Copy link
Collaborator Author

/hold wait for #2429 to merge first

- OneOf for password values
- Immutable for CloneSource
@jasonvigil
Copy link
Collaborator Author

/hold cancel

@jasonvigil
Copy link
Collaborator Author

A bit risky to add CEL for a v1beta1 resource, will do this for an alpha resource first.

@jasonvigil jasonvigil closed this Aug 28, 2024
@jasonvigil jasonvigil deleted the cloudsql-cel branch August 28, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants