Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bigqueryconnection cloudsql connection #2739

Merged

Conversation

600lyy
Copy link
Member

@600lyy 600lyy commented Sep 19, 2024

Change description

Add support for bigqueryconnection cloudsql connection

Run E2E test again realGCP:

KCC_USE_DIRECT_RECONCILERS=BigQueryConnectionConnection hack/record-gcp fixtures/cloudsqlconnectionbasic
  • [] Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Great job! I left some minor comments, and it will be ready to go.

apis/bigqueryconnection/v1alpha1/connection_types.go Outdated Show resolved Hide resolved
apis/bigqueryconnection/v1alpha1/connection_types.go Outdated Show resolved Hide resolved
apis/bigqueryconnection/v1alpha1/connection_types.go Outdated Show resolved Hide resolved
apis/refs/v1beta1/sqlinstanceref.go Outdated Show resolved Hide resolved
apis/refs/v1beta1/sqlinstanceref.go Outdated Show resolved Hide resolved
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks! All looks good

@google-oss-prow google-oss-prow bot added the lgtm label Sep 20, 2024
@google-oss-prow google-oss-prow bot merged commit 65a7c9c into GoogleCloudPlatform:master Sep 21, 2024
16 checks passed
@600lyy 600lyy deleted the mockgcp-bqcc-cover-all branch September 23, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants